Turn Impargs.implicit_status into a record. #18312
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ppedrot
added
kind: cleanup
coqbot-app
bot
removed
the
request: full CI
SkySkimmer
approved these changes
Nov 14, 2023
proux01
approved these changes
Nov 14, 2023
ejgallego
reviewed
Nov 14, 2023
| impl_max : maximal_insertion; | ||
| impl_force : force_inference; | ||
| } | ||
|
|
There was a problem hiding this comment.
Can we use a module to qualify this instead?
There was a problem hiding this comment.
I'm not a huge fan of this style, it makes grep unusable.
SkySkimmer
added
the
needs: overlay
ppedrot
added a commit
to ppedrot/coq-elpi
that referenced
this pull request
Nov 15, 2023
ppedrot
added a commit
to ppedrot/coq-serapi
that referenced
this pull request
Nov 15, 2023
ppedrot
added a commit
to ppedrot/vscoq
that referenced
this pull request
Nov 15, 2023
ppedrot
added
the
request: full CI
ppedrot
force-pushed
the
detuplify-impargs
branch
from
5210184 to
11608e1
Compare
coqbot-app
bot
removed
the
request: full CI
ppedrot
removed
the
needs: overlay
|
@coqbot merge now |
|
@SkySkimmer: Please take care of the following overlays:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trivial cleanup on my way to sorting out the mess we currently have with evar kinds.
Overlays: