Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow specifying the Docker repo for 'tested_coq_opam_versions' for use in coq-action.yml #59

Merged
merged 2 commits into from
Jun 26, 2020

Conversation

erikmd
Copy link
Member

@erikmd erikmd commented Jun 25, 2020

Follow-up of #57

@erikmd
Copy link
Member Author

erikmd commented Jun 25, 2020

just tested here the new docker-coq-action config (albeit with the default values, i.e., no custom repo) → ✔️

Copy link
Member

@palmskog palmskog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should try to keep the semantics of tested_coq_opam_versions the same across the different CI platforms as far as possible. Unfortunately, this PR introduces a different semantics compared the Travis CI one.

Consider the following definition in meta.yml:

tested_coq_opam_versions:
- version: '8.12'
- version: '1.11.0-coq-8.11'
  repo: 'mathcomp/mathcomp'

The expected meaning is that there is one run for the image coqorg/coq:8.12 and one run for the image mathcomp/mathcomp:1.11.0-coq-8.11. However, one instead gets coqorg/coq:8.12 and coqorg/coq:1.11.0-coq-8.11.

The easiest way to fix this is probably to replace image_version with just image, and specify the whole identifier (<repo>:<version>) of each image there.

@erikmd
Copy link
Member Author

erikmd commented Jun 26, 2020

@palmskog good point, I had not fully realized repo can be "local" to the version item :) I'm going to push a new commit.

@erikmd erikmd force-pushed the specify-docker-image branch from b528c86 to c55d207 Compare June 26, 2020 13:19
@palmskog
Copy link
Member

Thanks @erikmd, I tried the update version on one of my repos with different images and it works great. Let's merge this one now.

@palmskog palmskog merged commit 3e10852 into coq-community:master Jun 26, 2020
@erikmd erikmd deleted the specify-docker-image branch June 26, 2020 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants