Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docker Action: checkout v4 #125

Merged
merged 1 commit into from
Dec 4, 2024
Merged

Docker Action: checkout v4 #125

merged 1 commit into from
Dec 4, 2024

Conversation

liyishuai
Copy link
Member

Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3, actions/upload-artifact@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.

Zimmi48
Zimmi48 approved these changes Jan 31, 2024
View reviewed changes
Copy link
Member

@Zimmi48 Zimmi48 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! If this is tested, feel free to merge.

There are a number of other places where we should do a similar update BTW (e.g., the Nix template, the Coq Nix Toolbox, etc.).

@liyishuai
Copy link
Member Author

Tested in coq-community/coq-ext-lib@5b8f234
I'm not authorized to merge. Please proceed.

@liyishuai
Copy link
Member Author

@Zimmi48 are there pending tasks before merging this PR? The merge button is gray to me.

@Zimmi48
Copy link
Member

Zimmi48 commented Dec 4, 2024

Sorry, I missed your previous message!
I'm surprised that you cannot merge. Wasn't it the case before? Did we change anything in the configuration that could have had this effect @palmskog?
Anyway, merging this now.

@Zimmi48 Zimmi48 merged commit b22936e into master Dec 4, 2024
2 checks passed
@Zimmi48 Zimmi48 deleted the checkout-v4 branch December 4, 2024 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Zimmi48 Zimmi48 Zimmi48 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@liyishuai @Zimmi48