Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test with Alectryon 1.4 and Coq 8.14. #97

Merged
merged 3 commits into from
Oct 15, 2021
Merged

Test with Alectryon 1.4 and Coq 8.14. #97

merged 3 commits into from
Oct 15, 2021

Conversation

Zimmi48
Copy link
Member

@Zimmi48 Zimmi48 commented Oct 15, 2021

No description provided.

@Zimmi48
Copy link
Member Author

Zimmi48 commented Oct 15, 2021

This seems to work well. However, the update to Coq 8.14 creates new warnings that are reported in the Alectryon snippets (missing locality for Instance).

@Zimmi48
Copy link
Member Author

Zimmi48 commented Oct 15, 2021

This warning is already disabled in _CoqProject. Maybe we need a way to also report the warning disabling when calling SerAPI through Alectryon.

@cpitclaudel
Copy link
Contributor

For warnings that can be unconditionally disabled, we could use Global Set Warnings "-…". in a core file. I'm don't think that SerAPI has a way to customize warnings from the command line otherwise, but maybe there's a [protocol command that we could use for that if the Set Warnings route is not desirable.

@Zimmi48
Copy link
Member Author

Zimmi48 commented Oct 15, 2021

Global Set Warnings is frowned upon because of the transitive reach (beyond project boundaries). That's why command line arguments are usually preferred for that kind of stuff. That being said, in this precise case, I can also fix the warning by adding #[ global ] annotations everywhere they are missing.

@cpitclaudel
Copy link
Contributor

Makes sense, thanks!

@Zimmi48 Zimmi48 force-pushed the test-alectryon-1.4 branch from b75fa07 to ff8817c Compare October 15, 2021 16:16
@Zimmi48 Zimmi48 force-pushed the test-alectryon-1.4 branch from ff8817c to e4d4c3a Compare October 15, 2021 16:37
@Zimmi48 Zimmi48 merged commit c48e16c into master Oct 15, 2021
@palmskog palmskog deleted the test-alectryon-1.4 branch October 15, 2021 21:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants