Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to Alectryon 1.3 #57

Merged
merged 5 commits into from
Aug 16, 2021
Merged

Conversation

cpitclaudel
Copy link
Contributor

I've had a quick look at the output, and it seems reasonable to me; I hope I didn't break things. Please check and let me know.
I also took the liberty to fix a typo in the README and to use the new LuaLaTeX backend in Alectryon.

The update was supposed to be transparent, but I missed two trivial breaking changes; hence the patch :/ On the plus side, hypotheses and goals should display significantly better now.

As written they produce the following output:

    opam install coq-hydra-battles.opam --deps-only
    [ERROR] Package coq-hydra-battles has no version opam.
(It was removed it Alectryon 1.3.)
This is annoying oversight, sorry.  The function used to take a list of file
names and look them up in a hardcoded directory.  I generalized it to take lists
of (directory, name) pairs, but I didn't realize it had external callers.
@Casteran Casteran merged commit 6900eb5 into coq-community:master Aug 16, 2021
@Casteran
Copy link
Member

I've had a quick look at the output, and it seems reasonable to me; I hope I didn't break things. Please check and let me know.
I also took the liberty to fix a typo in the README and to use the new LuaLaTeX backend in Alectryon.

The update was supposed to be transparent, but I missed two trivial breaking changes; hence the patch :/ On the plus side, hypotheses and goals should display significantly better now.

@cpitclaudel Thank you very much !!!
In order to check goal displays, I just commit a change (remove a .no-out in theories/ordinals/Epsilon0/T1.v, snippet LTOnea, which is displayed p80 of the pdf. There is still a problem on my machine, but it may be a problem of local installation.

@Casteran
Copy link
Member

@cpitclaudel The same issue happens on CI.
I will temporarily restore the (* .no-out *) (4th line of Lemma LT_one), for having a clean hydras.pdf on the coq-community site.
For testing the vertical alignment of subgoals, it is possible to remove it, then touch doc/hydras.tex

@cpitclaudel cpitclaudel deleted the alectryon-1.3 branch August 16, 2021 21:00
@cpitclaudel
Copy link
Contributor Author

Thanks for testing. I see the problem now; I had built from inside Emacs and it used xelatex instead of lualatex by default. I will investigate.

cpitclaudel added a commit to cpitclaudel/alectryon that referenced this pull request Aug 17, 2021
A repeated call to alectryon@nohyphens clobbered the value of
alectryon@@hyphenpenalty, breaking the subsequent call to alectryon@hyphens.

Reported-by: @Casteran (coq-community/hydra-battles#57)
@cpitclaudel
Copy link
Contributor Author

OK, fixed in v1.3.1, thanks a lot.

image

By the way, if you prefer one hypothesis per line, you can use this:

\makeatletter
\renewcommand{\alectryon@hyps@sep}{\alectryon@nl}
\makeatother

image

@Casteran
Copy link
Member

Casteran commented Aug 17, 2021 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants