Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix scheme issue #116

Merged
merged 5 commits into from
Jan 25, 2022
Merged

Fix scheme issue #116

merged 5 commits into from
Jan 25, 2022

Conversation

Casteran
Copy link
Member

No description provided.

@Casteran
Copy link
Member Author

Casteran commented Jan 24, 2022 •
edited
Loading

Still a lot of warnings to fix (deprecated arith libraries).
To do later ...

@Casteran Casteran marked this pull request as ready for review January 25, 2022 10:39
@Casteran Casteran requested a review from palmskog January 25, 2022 10:39
palmskog
palmskog approved these changes Jan 25, 2022
View reviewed changes
Copy link
Member

@palmskog palmskog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, I think this is nicer than Set Apply With Renaming.. Only one About that could be removed.

theories/ordinals/Ackermann/fol.v Outdated Show resolved Hide resolved
@Casteran @palmskog
Update theories/ordinals/Ackermann/fol.v
bb4a917 
Co-authored-by: Karl Palmskog <palmskog@gmail.com>
@Casteran
Copy link
Member Author

Thanks! Note that Terms_Term_rec_full's Arguments are specified twice in fol.v, once inside a section, and once globally, with different variables. It took me a lot of Abouts to understand some error messages !

@Casteran Casteran merged commit d09db78 into master Jan 25, 2022
@Casteran Casteran deleted the fixSchemeIssue branch January 25, 2022 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@palmskog palmskog palmskog approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Casteran @palmskog