Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update addressable gem to v 2.8 to fix high severity security vulnerability #145

Closed
wants to merge 2 commits into from
Closed

Update addressable gem to v 2.8 to fix high severity security vulnerability #145

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2d54d6e
Update addressable gem to v 2.8 to fix high severity security vulnera…
JamieKD-RIFT Jul 13, 2021
7d90005
Add my personal account to the contributors list
JamieKD-RIFT Jul 13, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
88 changes: 44 additions & 44 deletions CONTRIBUTING.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,53 +8,53 @@ a feature you want that is not in here yet. As such, any and all bugs reports
are gratefully accepted, bugfixes even more so. Helping out with bugs is the
easiest way to contribute.


## The Quick Version

* Have a [GitHub Account][].
* Search the [GitHub Issues][] and see if your issue already present. If so
- Have a [GitHub Account][].
- Search the [GitHub Issues][] and see if your issue already present. If so
add your comments, :thumbsup:, etc.
* Issue not there? Not a problem, open up a [new issue][].
* **Bug reports** please be as detailed as possible. Include:
* full ruby engine and version: `ruby -e 'puts RUBY_DESCRIPTION'`
* operating system and version
* version of launchy `ruby -rubygems -Ilib -e "require 'launchy'; puts Launchy::VERSION"`
* as much detail about the bug as possible so I can replicate it. Feel free
to link in a [gist][]
* **New Feature**
* What the new feature should do.
* What benefit the new feature brings to the project.
* Fork the [repo][].
* Create a new branch for your issue: `git checkout -b issue/my-issue`
* Lovingly craft your contribution:
* `rake develop` to get started
* `bundle exec rake test` to run tests
* Make sure that `bundle exec rake test` passes. It's important, I said it twice.
* Add yourself to the contributors section below.
* Submit your [pull request][].
- Issue not there? Not a problem, open up a [new issue][].
- **Bug reports** please be as detailed as possible. Include:
- full ruby engine and version: `ruby -e 'puts RUBY_DESCRIPTION'`
- operating system and version
- version of launchy `ruby -rubygems -Ilib -e "require 'launchy'; puts Launchy::VERSION"`
- as much detail about the bug as possible so I can replicate it. Feel free
to link in a [gist][]
- **New Feature**
- What the new feature should do.
- What benefit the new feature brings to the project.
- Fork the [repo][].
- Create a new branch for your issue: `git checkout -b issue/my-issue`
- Lovingly craft your contribution:
- `rake develop` to get started
- `bundle exec rake test` to run tests
- Make sure that `bundle exec rake test` passes. It's important, I said it twice.
- Add yourself to the contributors section below.
- Submit your [pull request][].

# Contributors

* [Jeremy Hinegardner](https://github.com/copiousfreetime)
* [Mike Farmer](https://github.com/mikefarmer)
* [Suraj N. Kurapati](https://github.com/sunaku)
* [Postmodern](https://github.com/postmodern)
* [Stephen Judkins](https://github.com/stephenjudkins)
* [Mariusz Pietrzyk](https://github.com/wijet)
* [Bogdan Gusiev](https://github.com/bogdan)
* [Miquel Rodríguez Telep](https://github.com/mrtorrent)
* [Chris Schmich](https://github.com/schmich)
* [Gioele Barabucci](https://github.com/gioele)
* [Colin Noel Bell](https://github.com/colbell)
* [Mark J. Lehman](https://github.com/supremebeing7)
* [Cédric Félizard](https://github.com/infertux)
* [Daniel Farina](https://github.com/fdr)
* [Jack Turnbull](https://github.com/jackturnbull)
* [Jeremy Moritz](https://github.com/jeremymoritz)

[GitHub Account]: https://github.com/signup/free "GitHub Signup"
[GitHub Issues]: https://github.com/copiousfreetime/launchy/issues "Launchy Issues"
[new issue]: https://github.com/copiousfreetime/launchy/issues/new "New Launchy Issue"
[gist]: https://gist.github.com/ "New Gist"
[repo]: https://github.com/copiousfreetime/launchy "Launchy Repo"
[pull request]: https://help.github.com/articles/using-pull-requests "Using Pull Requests"
- [Jeremy Hinegardner](https://github.com/copiousfreetime)
- [Mike Farmer](https://github.com/mikefarmer)
- [Suraj N. Kurapati](https://github.com/sunaku)
- [Postmodern](https://github.com/postmodern)
- [Stephen Judkins](https://github.com/stephenjudkins)
- [Mariusz Pietrzyk](https://github.com/wijet)
- [Bogdan Gusiev](https://github.com/bogdan)
- [Miquel Rodríguez Telep](https://github.com/mrtorrent)
- [Chris Schmich](https://github.com/schmich)
- [Gioele Barabucci](https://github.com/gioele)
- [Colin Noel Bell](https://github.com/colbell)
- [Mark J. Lehman](https://github.com/supremebeing7)
- [Cédric Félizard](https://github.com/infertux)
- [Daniel Farina](https://github.com/fdr)
- [Jack Turnbull](https://github.com/jackturnbull)
- [Jeremy Moritz](https://github.com/jeremymoritz)
- [Jamie Donnelly](https://github.com/JamieKDonnelly)

[github account]: https://github.com/signup/free "GitHub Signup"
[github issues]: https://github.com/copiousfreetime/launchy/issues "Launchy Issues"
[new issue]: https://github.com/copiousfreetime/launchy/issues/new "New Launchy Issue"
[gist]: https://gist.github.com/ "New Gist"
[repo]: https://github.com/copiousfreetime/launchy "Launchy Repo"
[pull request]: https://help.github.com/articles/using-pull-requests "Using Pull Requests"
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Prettier did its thang! Should we keep?

2 changes: 1 addition & 1 deletion Rakefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ This.email = "jeremy@copiousfreetime.org"
This.homepage = "https://github.com/copiousfreetime/#{ This.name }"

This.ruby_gemspec do |spec|
spec.add_dependency( 'addressable', '~> 2.7')
spec.add_dependency( 'addressable', '~> 2.8')

spec.add_development_dependency( 'rake' , '~> 13.0')
spec.add_development_dependency( 'minitest' , '~> 5.14' )
Expand Down
10 changes: 5 additions & 5 deletions launchy.gemspec
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ Gem::Specification.new do |s|
s.metadata = { "bug_tracker_uri" => "https://github.com/copiousfreetime/launchy/issues", "changelog_uri" => "https://github.com/copiousfreetime/launchy/blob/master/README.md", "homepage_uri" => "https://github.com/copiousfreetime/launchy", "source_code_uri" => "https://github.com/copiousfreetime/launchy" } if s.respond_to? :metadata=
s.require_paths = ["lib".freeze]
s.authors = ["Jeremy Hinegardner".freeze]
s.date = "2020-05-20"
s.date = "2021-07-13"
s.description = "Launchy is helper class for launching cross-platform applications in a fire and forget manner. There are application concepts (browser, email client, etc) that are common across all platforms, and they may be launched differently on each platform. Launchy is here to make a common approach to launching external applications from within ruby programs.".freeze
s.email = "jeremy@copiousfreetime.org".freeze
s.executables = ["launchy".freeze]
Expand All @@ -21,28 +21,28 @@ Gem::Specification.new do |s|
s.licenses = ["ISC".freeze]
s.rdoc_options = ["--main".freeze, "README.md".freeze, "--markup".freeze, "tomdoc".freeze]
s.required_ruby_version = Gem::Requirement.new(">= 2.4.0".freeze)
s.rubygems_version = "3.0.3".freeze
s.rubygems_version = "3.0.8".freeze
s.summary = "Launchy is helper class for launching cross-platform applications in a fire and forget manner.".freeze
s.test_files = ["spec/application_spec.rb".freeze, "spec/applications/browser_spec.rb".freeze, "spec/cli_spec.rb".freeze, "spec/detect/host_os_family_spec.rb".freeze, "spec/detect/host_os_spec.rb".freeze, "spec/detect/nix_desktop_environment_spec.rb".freeze, "spec/detect/ruby_engine_spec.rb".freeze, "spec/detect/runner_spec.rb".freeze, "spec/launchy_spec.rb".freeze, "spec/mock_application.rb".freeze, "spec/spec_helper.rb".freeze, "spec/tattle-host-os.yaml".freeze, "spec/version_spec.rb".freeze]

if s.respond_to? :specification_version then
s.specification_version = 4

if Gem::Version.new(Gem::VERSION) >= Gem::Version.new('1.2.0') then
s.add_runtime_dependency(%q<addressable>.freeze, ["~> 2.7"])
s.add_runtime_dependency(%q<addressable>.freeze, ["~> 2.8"])
s.add_development_dependency(%q<rake>.freeze, ["~> 13.0"])
s.add_development_dependency(%q<minitest>.freeze, ["~> 5.14"])
s.add_development_dependency(%q<rdoc>.freeze, ["~> 6.2"])
s.add_development_dependency(%q<simplecov>.freeze, ["~> 0.18"])
else
s.add_dependency(%q<addressable>.freeze, ["~> 2.7"])
s.add_dependency(%q<addressable>.freeze, ["~> 2.8"])
s.add_dependency(%q<rake>.freeze, ["~> 13.0"])
s.add_dependency(%q<minitest>.freeze, ["~> 5.14"])
s.add_dependency(%q<rdoc>.freeze, ["~> 6.2"])
s.add_dependency(%q<simplecov>.freeze, ["~> 0.18"])
end
else
s.add_dependency(%q<addressable>.freeze, ["~> 2.7"])
s.add_dependency(%q<addressable>.freeze, ["~> 2.8"])
s.add_dependency(%q<rake>.freeze, ["~> 13.0"])
s.add_dependency(%q<minitest>.freeze, ["~> 5.14"])
s.add_dependency(%q<rdoc>.freeze, ["~> 6.2"])
Expand Down