add: Added text centering options #206
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@cooperka this is nice have, would it be possible to get it merged? |
cooperka
approved these changes
Sep 26, 2024
| if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.M){ | ||
| snackbarText.setTextAlignment(View.TEXT_ALIGNMENT_TEXT_START); | ||
| } else { | ||
| snackbarText.setGravity(Gravity.START); |
There was a problem hiding this comment.
My only concern is that this runs new code by default where it did nothing before, which could subtly alter how it looks on certain devices. I assume it won't change anything.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I wanted an option to center the label text, so we added it. Please review.