Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix crash when refusing order from the Order page #4876

Merged
merged 1 commit into from
Feb 6, 2025
Merged

Conversation

Atala
Copy link
Member

@Atala Atala commented Jan 30, 2025

#4875

Refused order status is also valid when all tasks of a delivery are cancelled

@Atala Atala requested a review from alexsegura January 30, 2025 08:59
@Atala Atala linked an issue Jan 30, 2025 that may be closed by this pull request
@r0xsh
Copy link
Member

r0xsh commented Feb 5, 2025

Should allow transition from refused to cancelled into state_machine.yml

Copy link
Member

@alexsegura alexsegura left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You could also just allow the transition from refused to cancelled in app/config/state_machine.yml

cancel:
  from: [new, accepted, started, ready, refused]
  to: cancelled

@Atala Atala force-pushed the fix-crash-on-refuse branch from 274d348 to 4b53d42 Compare February 6, 2025 09:08
@Atala Atala force-pushed the fix-crash-on-refuse branch from 4b53d42 to 5f94e76 Compare February 6, 2025 09:14
@Atala Atala merged commit a411675 into master Feb 6, 2025
5 of 6 checks passed
@Atala Atala deleted the fix-crash-on-refuse branch February 6, 2025 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Crash when refusing an order from the admin interface
3 participants