Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Imports of com.kbeanie.imagechooser.R should be removed #38

Closed
fraserscottmorrison opened this issue Aug 18, 2014 · 3 comments
Closed

Imports of com.kbeanie.imagechooser.R should be removed #38

fraserscottmorrison opened this issue Aug 18, 2014 · 3 comments
Assignees
@coomar2841
Labels
bug

Comments

@fraserscottmorrison
Copy link

ImageChooseBuilder & VideoChooserBuilder both import com.kbeanie.imagechooser.R to access strings. It makes it impossible to use these files in another project without modifying them.

You could instead use properties, with hardcoded default values, which can be overridden.
@coomar2841
Copy link
Owner

Good point. Will change this soon. Thanks. :)

@coomar2841 coomar2841 added the bug label Aug 19, 2014
@coomar2841 coomar2841 self-assigned this Aug 19, 2014
coomar2841 added a commit that referenced this issue Sep 30, 2014
@coomar2841
Issue #38
da56795
@coomar2841
Copy link
Owner

Fixed in the dev branch. Would be available with the next release

@coomar2841
Copy link
Owner

Done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@coomar2841 coomar2841

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@coomar2841 @fraserscottmorrison