Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #1604 - FilePlayer does not work if I passed an array of urls #1612

Merged

Commits on Aug 31, 2023

  1. Fix cookpete#1604 - FilePlayer does not work if I passed an array of …

    …urls
    
    PR cookpete#1538 was setting the src of the video element to undefined. Because
    of this, even if the users passed an array of urls, the video element
    would not play becuase it got a `src` of `undefined`;
    
    After fixing the undefined `src` issue, another PR was making a infinite
    loop issue when user passed an array of urls. There, the author set the
    `srcObject` to null. There as well, a check for `url` prop was missing.
    
    This PR aims to fix both of these overlooked aspects.
    anampartho authored and cookpete committed Aug 31, 2023
    Configuration menu
    Copy the full SHA
    0f145ed View commit details
    Browse the repository at this point in the history