Fix exposing kube-proxy metrics #124
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When kube-proxy is configured with a config file, trying to change settings with a cmd flag doesn't work. This pulls in the eks provisioned config-map and changes `metricsBindAddress` from `127.0.0.1:10249` to `0.0.0.0:10249`
ettiee
added a commit
that referenced
this pull request
Dec 21, 2021
The EKS addon for kube-proxy introduced regressions of #124 and #209. We will apply the recommended overrides from aws/containers-roadmap#657 and aws/amazon-vpc-cni-k8s#1702 in the manifests until the EKS addon applies these by default or allows you to override config in the addon.
ettiee
added a commit
that referenced
this pull request
Dec 22, 2021
The EKS addon for kube-proxy introduced regressions of #124 and #209. We will apply the recommended overrides from aws/containers-roadmap#657 and aws/amazon-vpc-cni-k8s#1702 in the manifests until the EKS addon applies these by default or allows you to override config in the addon.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When kube-proxy is configured with a config file, trying to change
settings with a cmd flag doesn't work.
This pulls in the eks provisioned config-map and changes
metricsBindAddressfrom127.0.0.1:10249to0.0.0.0:10249