Ahmed qaisar/improve test coverage of production build/config #4647
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…config' of https://github.com/Ahmed-Qaisar/cookiecutter-django into Ahmed-Qaisar/Improve-test-coverage-of-production-build/config
…config' of https://github.com/Ahmed-Qaisar/cookiecutter-django into Ahmed-Qaisar/Improve-test-coverage-of-production-build/config
…config' of https://github.com/Ahmed-Qaisar/cookiecutter-django into Ahmed-Qaisar/Improve-test-coverage-of-production-build/config
…config' of https://github.com/Ahmed-Qaisar/cookiecutter-django into Ahmed-Qaisar/Improve-test-coverage-of-production-build/config
…config' of https://github.com/Ahmed-Qaisar/cookiecutter-django into Ahmed-Qaisar/Improve-test-coverage-of-production-build/config
…config' of https://github.com/Ahmed-Qaisar/cookiecutter-django into Ahmed-Qaisar/Improve-test-coverage-of-production-build/config
…config' of https://github.com/Ahmed-Qaisar/cookiecutter-django into Ahmed-Qaisar/Improve-test-coverage-of-production-build/config
…config' of https://github.com/Ahmed-Qaisar/cookiecutter-django into Ahmed-Qaisar/Improve-test-coverage-of-production-build/config
…config' of https://github.com/Ahmed-Qaisar/cookiecutter-django into Ahmed-Qaisar/Improve-test-coverage-of-production-build/config
|
How is everything coming along @Ahmed-Qaisar? Is it ready for review? |
|
Done in #4838 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I've introduced automated checks for the production build and configuration. This includes simulating a production build in the CI/CD pipeline, installing production dependencies, and running the Django command manage.py check --deploy to check for any deployment-specific issues. This ensures that our CI covers the production setup, addressing concerns that some issues might only be caught during an actual deployment.
Checklist:
Rationale
The project previously lacked coverage for the production setup in the CI, which meant potential issues might only be identified during an actual deployment. This change ensures that the production setup is tested automatically, reducing the risk of deployment-specific issues. This addresses and resolves the concerns raised in issue Fix #4462.