introduce GetFn and PeekFn methods, for zero-copy access.
#92
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit introduces two methods GetFn and PeekFn. These methods provide zero-copy access to cache entries, avoiding allocs unless absolutely necessary. They accept a function, and call it with a slice over the current underlying value of the key in memory. The slice is constrained in length and capacity. The RingBuf struct has been augmented with a Slice() method to support these operations. The only case where these variants allocate is when the value wraps around the ring buffer.
This was referenced Nov 15, 2020
|
Good job! |
|
Hi @raulk, it seems that this commit caused degradation of performance. Could you check it please? Reproducer: Before: After: Shall I create an issue for it? FYI @coocood |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit introduces two methods GetFn and PeekFn. These methods provide zero-copy access to cache entries, avoiding allocs unless absolutely necessary.
They accept a function, and call it with a slice over the current underlying value of the key in memory. The slice is constrained in length and capacity. The RingBuf struct has been augmented with a Slice() method to support these operations.
The only case where these variants allocate is when the value wraps around the ring buffer.