Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump vscode to 1.96.2 #614

Merged
merged 1 commit into from
Jan 11, 2025
Merged

chore: bump vscode to 1.96.2 #614

merged 1 commit into from
Jan 11, 2025

Conversation

conwnet
Copy link
Owner

@conwnet conwnet commented Jan 11, 2025

Due to VSCode now switching to ESM, a major change has been made to the entire build process, and GitHub1s has also been changed to ESM. In addition, like VSCode, npm has been switched to as the package management tool here.

Furthermore, most of dependencies have also been updated.

Copy link

cloudflare-workers-and-pages bot commented Jan 11, 2025

Deploying github1s with  Cloudflare Pages  Cloudflare Pages

Latest commit: 4b38d58
Status: ✅  Deploy successful!
Preview URL: https://fdf08c3a.github1s-dld.pages.dev
Branch Preview URL: https://bump-vscode.github1s-dld.pages.dev

View logs

@conwnet conwnet force-pushed the bump-vscode branch 2 times, most recently from 01acdd2 to 1a252e7 Compare January 11, 2025 10:24
import HtmlWebpackPlugin from 'html-webpack-plugin';
import * as packUtils from './scripts/webpack.js';

const commitId = cp.execSync('git rev-parse HEAD').toString().trim();

Check warning

Code scanning / Jshint (reported by Codacy)

'require' is not defined. Warning

'require' is not defined.
import HtmlWebpackPlugin from 'html-webpack-plugin';
import * as packUtils from './scripts/webpack.js';

const commitId = cp.execSync('git rev-parse HEAD').toString().trim();

Check notice

Code scanning / Jshint (reported by Codacy)

Prohibits the use of __iterator__ property due to compatibility issues Note

'const' is available in ES6 (use 'esversion: 6') or Mozilla JS extensions (use moz).
const skipMinified = { info: { minimized: true } };
const skipNodeModules = { globOptions: { dot: true, ignore: ['**/node_modules/**'] } };

Check warning

Code scanning / Jshint (reported by Codacy)

'__dirname' is not defined. Warning

'__dirname' is not defined.
@conwnet conwnet marked this pull request as draft January 11, 2025 10:43
const skipMinified = { info: { minimized: true } };
const skipNodeModules = { globOptions: { dot: true, ignore: ['**/node_modules/**'] } };

Check warning

Code scanning / Jshint (reported by Codacy)

'module' is not defined. Warning

'module' is not defined.
import HtmlWebpackPlugin from 'html-webpack-plugin';
import * as packUtils from './scripts/webpack.js';

const commitId = cp.execSync('git rev-parse HEAD').toString().trim();

Check warning

Code scanning / Eslint-9 (reported by Codacy)

Definition for rule '@typescript-eslint/no-require-imports' was not found. Warning

Definition for rule '@typescript-eslint/no-require-imports' was not found.
@conwnet conwnet force-pushed the bump-vscode branch 5 times, most recently from 3f5f48c to 27df49f Compare January 11, 2025 15:47
Copy link
Collaborator

@Siddhant-K-code Siddhant-K-code left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are good to go 🚀

@Siddhant-K-code Siddhant-K-code marked this pull request as ready for review January 11, 2025 17:42
Copy link
Collaborator

@Siddhant-K-code Siddhant-K-code left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are good to go 🚀 :shipit:

@conwnet conwnet merged commit 9b593c6 into master Jan 11, 2025
15 checks passed
@conwnet conwnet deleted the bump-vscode branch January 11, 2025 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants