Prevent undefined values when adding a new Connection Profile

convos-chat · Mar 18, 2024 · c0c63ad · c0c63ad
1 parent a234d8f
commit c0c63ad
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 3 deletions.
diff --git a/assets/page/ConnectionProfileSettings.svelte b/assets/page/ConnectionProfileSettings.svelte
@@ -22,14 +22,14 @@ const connectionProfiles = user.connectionProfiles;
 const removeConnectionProfileOp = convosApi.op('removeConnectionProfile');
 const saveConnectionProfileOp = convosApi.op('saveConnectionProfile');
 
-let form = {};
+let form = connectionProfiles.defaultProfile();
 let showAdvancedSettings = false;
 
 $: isAdmin = user.roles.has('admin');
 
 onMount(async () => {
   await connectionProfiles.load();
-  form = {...($connectionProfiles.find(profile_id) || $connectionProfiles.defaultProfile())};
+  Object.assign(form, connectionProfiles.defaultProfile(), $connectionProfiles.find(profile_id) || {});
 });
 
 async function removeConnectionProfile() {

diff --git a/assets/store/ConnectionProfiles.js b/assets/store/ConnectionProfiles.js
@@ -15,7 +15,20 @@ export default class ConnectionProfiles extends Reactive {
   }
 
   defaultProfile() {
-    return {max_bulk_message_size: 3, max_message_length: 512, url: new ConnectionURL('irc://0.0.0.0')};
+    return {
+      conversation_id: '',
+      host: '',
+      is_default: false,
+      is_forced: true,
+      max_bulk_message_size: 3,
+      max_message_length: 512,
+      service_accounts: 'chanserv, nickserv',
+      skip_queue: false,
+      tls: true,
+      tls_verify: true,
+      webirc_password: '',
+      url: new ConnectionURL('irc://0.0.0.0'),
+    };
   }
 
   is(status) {