Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: set lato as the default font and use montserrat for headings #16

Merged
merged 1 commit into from
Dec 11, 2024

Conversation

anoblet
Copy link
Collaborator

@anoblet anoblet commented Nov 14, 2024

https://app.clickup.com/t/86b2pt9td

Description

This PR solves # .

Steps completed:

According to our definition of done, I have completed the following steps:

  • Acceptance criteria met
  • Unit tests added
  • Docs updated (including config and env variables)
  • Translations added
  • UX tested
  • Browsers / platforms tested
  • Rebased & ready to merge without conflicts
  • Reviewed own code

@anoblet anoblet requested review from lkraav and pawelkmpt November 14, 2024 15:22
@anoblet anoblet self-assigned this Nov 14, 2024
@lkraav
Copy link

lkraav commented Nov 14, 2024

I think "headings", not "headers"?

@anoblet anoblet force-pushed the anoblet/fix/typography branch from 617e01c to 8666bd8 Compare November 14, 2024 15:43
@anoblet anoblet changed the title fix: set lato as the default font and use montserrat for headers fix: set lato as the default font and use montserrat for headings Nov 14, 2024
Copy link

@pawelkmpt pawelkmpt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • we should avoid using !important especially for such basic rule
  • file you put rules in only defines variables, we should follow this approach and place actual rules somewhere else
  • find where $body-alt-font-family is used. maybe it's a matter of editing this var? if not maybe we need one more var to be placed in headings across the styles

@anoblet
Copy link
Collaborator Author

anoblet commented Nov 15, 2024

$body-font-family and $body-alt-font-family are pretty ubiquitous, and are polished on the component level. Replacing font family on a global level for headings is the best strategy?

@anoblet
Copy link
Collaborator Author

anoblet commented Nov 15, 2024

I'll take a look on Monday and see if there's a way to create more specificity.

@anoblet anoblet force-pushed the anoblet/fix/typography branch from 8666bd8 to 85e5ce9 Compare December 9, 2024 19:09
@anoblet
Copy link
Collaborator Author

anoblet commented Dec 9, 2024

I moved the rule into a separate file(_custom.scss). As for the specificity, it's difficult to not use important since font-family is defined in hundreds of components, and the generated class for each component takes precedence. A mass search and replace would make it harder to sync upstream at a later date.

@pawelkmpt pawelkmpt merged commit 2de8408 into cxl-main Dec 11, 2024
3 of 5 checks passed
@pawelkmpt pawelkmpt deleted the anoblet/fix/typography branch December 11, 2024 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants