Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cxl-ui): migrate to lit #160

Closed
wants to merge 2 commits into from
Closed

Conversation

anoblet
Copy link
Collaborator

@anoblet anoblet commented Jun 10, 2021

No description provided.

@anoblet anoblet requested a review from lkraav June 10, 2021 17:10
@anoblet anoblet changed the title chore(cxl-ui): migrate to lit feat(cxl-ui): migrate to lit Jun 11, 2021
@anoblet
Copy link
Collaborator Author

anoblet commented Jun 11, 2021

  • Formatting happens automatically on commit.
  • Unable to migrate cxl-lumo-styles because of an instanceOf check.

import { CSSResult } from 'lit-element';

if (!(cssResult instanceof CSSResult)) {

@anoblet
Copy link
Collaborator Author

anoblet commented Jun 14, 2021

What are your thoughts on https://twitter.com/serhiikulykov/status/1392156377838145536 @anoblet

@lkraav That looks pretty awesome. Upgrading Vaadin components will be it's own beast I feel.

@anoblet anoblet mentioned this pull request Sep 13, 2021
@lkraav lkraav force-pushed the master branch 6 times, most recently from 83befa9 to a0ab69d Compare October 14, 2021 14:12
@anoblet anoblet closed this Jun 3, 2022
@lkraav lkraav deleted the lit branch June 3, 2022 12:23
@lkraav
Copy link

lkraav commented Jun 3, 2022

#184 or later takes over.

@anoblet anoblet restored the lit branch June 3, 2022 12:30
@anoblet anoblet deleted the lit branch June 3, 2022 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants