Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(cxl-ui): upgrade @vaadin/web-components to v.21.0.0-alpha-3 #149

Closed
wants to merge 5 commits into from
Closed

chore(cxl-ui): upgrade @vaadin/web-components to v.21.0.0-alpha-3 #149

wants to merge 5 commits into from

Conversation

anoblet
Copy link
Collaborator

@anoblet anoblet commented Jun 2, 2021

No description provided.

@anoblet anoblet marked this pull request as draft June 2, 2021 13:52
@anoblet
Copy link
Collaborator Author

anoblet commented Jun 2, 2021 •
edited
Loading

Upgrade breaks CXL Lumo Styles/Elements

@anoblet
Copy link
Collaborator Author

anoblet commented Jun 2, 2021

Also introduces an endless build:

aybolit.-.Visual.Studio.Code.2021-06-02.11-28-47.mp4

@anoblet anoblet linked an issue Jun 2, 2021 that may be closed by this pull request
chore(cxl-ui): @vaadin/web-components to v.21.0.0-alpha-3 #148
Closed
@anoblet anoblet mentioned this pull request Jun 2, 2021
Closed
@lkraav
Copy link

lkraav commented Jun 3, 2021

Upgrade breaks CXL Lumo Styles/Elements

Salvageable?

@anoblet
Copy link
Collaborator Author

anoblet commented Jun 3, 2021 •
edited
Loading

I believe so. This pops up in console:

vendors~main.3f3ecec1.iframe.bundle.js:2 Unexpected error while loading ./cxl-lumo-styles/elements.stories.js: NotSupportedError: Failed to execute 'define' on 'CustomElementRegistry': the name "vaadin-lumo-styles" has already been used with this registry

Commenting the import out in elements.stories.js breaks styles across the board.

It's a regression introduced by this commit alone... I'm hoping it's a user-land issue.

@lkraav
Copy link

lkraav commented Jun 3, 2021

Failed to execute 'define' on 'CustomElementRegistry': the name "vaadin-lumo-styles" has already been used with this registry

Historically, this has been about multiple packages copies in node_modules/ 🤔

lkraav
lkraav reviewed Jun 3, 2021
View reviewed changes
@anoblet
Copy link
Collaborator Author

anoblet commented Jun 3, 2021 •
edited
Loading

Historically, this has been about multiple packages copies in node_modules/ 🤔

I've run git clean -fxd && yarn install && yarn build more times than I can count.

I bumped @vaadin/vaadin-themable-mixin still the same issue.

@anoblet
Copy link
Collaborator Author

anoblet commented Jun 8, 2021

/rebase

@lkraav lkraav force-pushed the master branch 6 times, most recently from 83befa9 to a0ab69d Compare October 14, 2021 14:12
@anoblet anoblet closed this Dec 10, 2021
@anoblet
Copy link
Collaborator Author

anoblet commented Dec 10, 2021

New PR: #184

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lkraav lkraav lkraav left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

chore(cxl-ui): @vaadin/web-components to v.21.0.0-alpha-3
2 participants
@anoblet @lkraav