Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch from private Unicode ranges to proper SVG images #1004

Closed
linkmauve opened this issue Jan 27, 2018 · 4 comments
Closed

Switch from private Unicode ranges to proper SVG images #1004

linkmauve opened this issue Jan 27, 2018 · 4 comments

Comments

@linkmauve
Copy link
Contributor

linkmauve commented Jan 27, 2018

Using a font with images in some private Unicode range is a hack, which degrades very poorly for users who don’t use @font-face for any reason.

They should be replaced with proper images.


Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

@jcbrand jcbrand added the wontfix label Apr 2, 2018
@jcbrand
Copy link
Member

jcbrand commented Apr 2, 2018

Currently in the master branch the fonts are included in the CSS so users won't load the CSS without the fonts. The fonts are also named in a way to avoid collisions.

Using fonts works well and lots of projects do it. If it were to eventually become a problem we could change to images, but I don't see a need to do so now and there's many more important things to spend time on. To prevent clutter I'm closing this ticket.

@jcbrand jcbrand closed this as completed Apr 2, 2018
@linkmauve
Copy link
Contributor Author

It actually already is a problem, not all CSS parsers support @font-face, it also is an accessibility feature to disable it since many websites become unreadable with them.

See also https://github.com/blog/2112-delivering-octicons-with-svg for a more technical reasoning.

@jcbrand
Copy link
Member

jcbrand commented Apr 4, 2018

OK,I'll reopen, but is not something I'm personally motivated to work on. There's IMO many other higher priority things to do.

@jcbrand jcbrand reopened this Apr 4, 2018
@jcbrand
Copy link
Member

jcbrand commented Sep 4, 2018

This looks like helpful and relevant information:

https://fontawesome.com/how-to-use/on-the-web/advanced/svg-sprites

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants