-
Notifications
You must be signed in to change notification settings - Fork 798
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
.versionrc.json is not being loaded #371
Comments
bug in standard-version@6.0.1 does not load `.versionrc.json` conventional-changelog/standard-version#371
- Updates the configuration retrieval to support Javascript (`.js`) configurations. - Javascript configurations MUST export a configuration object _or_ a function (returning a configuration object) as the default export. closes #371
Hey! Thanks for the report – this actually isn't supported in the current release, but I've opened a PR that should account for this functionality. |
@jbottigliero I'm a bit confused, I think this issue relates to I would however love to fix this bug. |
Whoa, yeah... I’ve confused myself. Taking a second look at this... Let me review the tests and see what’s going on here! |
I can confirm that |
Is this addressed? The PR hasn't been merged yet. |
Yes, it's working in 7.0.0. Not sure what changed, but it definitely works. |
- Updates the configuration retrieval to support Javascript (`.js`) configurations. - Javascript configurations MUST export a configuration object _or_ a function (returning a configuration object) as the default export. closes #371
* feat(configuration): .versionrc.js files are now supported - Updates the configuration retrieval to support Javascript (`.js`) configurations. - Javascript configurations MUST export a configuration object _or_ a function (returning a configuration object) as the default export. closes #371 * docs: Updates README to include details for the new '.versionrc.js' support * fix: updates error message to be a bit more descriptive and helpful.
.versionrc.json
is not being loaded currently, only.versionrc
. This is my.versionrc.json
file currently:When I run, note that there's no precommit hook executed:
But if I move
.versionrc.json
to.versionrc
and retry, it does execute the hook.Tested on v6.0.1.
The text was updated successfully, but these errors were encountered: