Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

if private module don't append --tag prerelease #294

Closed
whyvez opened this issue Jan 16, 2019 · 1 comment · Fixed by #296
Closed

if private module don't append --tag prerelease #294

whyvez opened this issue Jan 16, 2019 · 1 comment · Fixed by #296
Labels

Comments

@whyvez
Copy link

whyvez commented Jan 16, 2019

standard-version 4.4.0

I've run into an issue with a prerelease for a private module where the --tag prerelease npm publish option was appended to the final git push help text.

✔ bumping version in package.json from 1.2.0-beta.4 to 1.2.0-dev.0
✔ bumping version in package-lock.json from 1.2.0-beta.4 to 1.2.0-dev.0
✔ outputting changes to CHANGELOG.md
✔ committing package-lock.json and package.json and CHANGELOG.md
✔ tagging release v1.2.0-dev.0
ℹ Run `git push --follow-tags origin master --tag prerelease` to publish

Need to wrap this logic within the if (pkgPrivate !== true) condition.

refs: #183 (reference)

@stevemao stevemao added the bug label Jan 16, 2019
@stevemao
Copy link
Member

Thanks @whyvez , must be a bug.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging a pull request may close this issue.

2 participants