Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: update var to let/const #276

Closed
bcoe opened this issue Nov 3, 2018 · 2 comments
Closed

chore: update var to let/const #276

bcoe opened this issue Nov 3, 2018 · 2 comments
Assignees
@hutson
Labels
enhancement

Comments

@bcoe
Copy link
Member

bcoe commented Nov 3, 2018

It might be worthwhile doing a bit of work to go through the codebase and update vars to let and const -- which have lexical scoping rules that make it harder to shoot yourself in the foot.
@bcoe bcoe mentioned this issue Nov 3, 2018
Merged
@stevemao
Copy link
Member

stevemao commented Nov 3, 2018 •
edited
Loading

eslint should be able to auto-fix this.

jbottigliero pushed a commit to jbottigliero/standard-version that referenced this issue Mar 30, 2019
chore: Updates var usage to let
80cec38 
- No longer uses `standard` directly, instead uses the [recommmend manual configuration](https://github.com/standard/eslint-config-standard) to allow for the addition of the [`no-var`](https://eslint.org/docs/rules/no-var) eslint rule.
- Uses `eslint . --fix` after the configuration update to swap `var` usage to `let`

see conventional-changelog#276
@jbottigliero jbottigliero mentioned this issue Mar 30, 2019
Merged
@bcoe
Copy link
Member Author

bcoe commented May 5, 2019

this has been done 👍

@bcoe bcoe closed this as completed May 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hutson hutson

Labels
enhancement
Milestone
No milestone
Development

No branches or pull requests
3 participants
@bcoe @stevemao @hutson