-
Notifications
You must be signed in to change notification settings - Fork 798
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
How to bump/generate changelog and commit/push in a second time #157
Comments
Maybe something like this:
? |
…--skip-bump-and-changelog option, and to skip the commit/tag/push phase by using --skip-commit option closes conventional-changelog#157
Finaly I chose Let me know what you think about that. Thanks |
…--skip-bump-and-changelog option, and to skip the commit/tag/push phase by using --skip-commit option closes conventional-changelog#157
…--skip-bump-and-changelog option, and to skip the commit/tag/push phase by using --skip-commit option closes conventional-changelog#157
Hi, thanks for opening an issue! There has been discussion about adding a "lifecycle" style hook between the bump and commit phases, but the So, a possible fix to your situation would be to:
I see the pull request you created, but what do you think about a lifecycle hook instead, since that forces making the process streamlined, instead of breaking up execution (which might complicate maintenance 😢 )? |
Thank you for your answer. Actually I need to embed into the generated artifact the up to date changelog. So that's why I suggested to be able to run the process in 2 times:
About your suggestions:
About the hook you mentioned, correct me if I didn't understand what you mean, it would be a possibility for me to add some actions (build my artifact for example) between the bump/changelog phase and the commit/tag/push phase? That's it? It could fits my need I think. How it would be used? A intermediary npm script runned by standard-version between the 2 phases?
Something like that? |
Yeah you got it right, something like that exactly. I think it might have come time to actually implement it as I can't figure out another solution to your problem. @stevemao @bcoe @nexdrew Any comments about the configuration / naming for this? Should we start the package.json stanza or use a prenamed script from the scripts section? I previously threw around a |
What came of this idea? I see it's still open, but this is my exact use case. I generate a "version.js" file which I add to my src, then build a front end bundle via webpack (or obviously allow others to import via webpack). My solution was a hacked version of standard-version which adds a third input argument which is a "precommit" callback to allow build artifacts to be generated which require the new version number prior to commit. I would much rather have an official option and the lifecycle hooks sounds ideal (wish I'd taken that approach then I'd have a PR instead of this comment). |
…ed in <cwd>/.standard-version/hooks Closes conventional-changelog#157
…ed in <cwd>/.standard-version/hooks Closes #157
…ed in <cwd>/.standard-version/hooks Closes #157
Hello,
I need to embed the version number and the changelog in the generated artifact of my application.
So I would like to be able to bump the version and generate the changelog first, then build my application, then create the commit, tag and push everything.
How to do that with standard-version ?
Thanks in advance for your help
The text was updated successfully, but these errors were encountered: