-
Notifications
You must be signed in to change notification settings - Fork 918
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: error TS2307: Cannot find module 'conventional-commits-parser' or its corresponding type declarations. #3942
Comments
Also happens with latest version? |
I'm not pinning to a specific old version, so it's always installing the last. And the last time my CI ran was 5 mins ago. So: yes. |
I'm trying to find what went wrong here, and I've found this npm pkg: |
Is this PR related? #3929 |
We only use |
The last version of commitlint is making our tests fail. My suspicions for why are the following: a) After their massive refactoring migrating to ESM [1], they somehow changed their sub-package @commitlint/types, which I reported as bug 3942 [2]. b) When fixing bug 3942 [3], they updated their dependency to `@types/conventional-commits-parser` to a higher version (from 3.0.6 to 5.0.0). Version 5.0.0 of that package is about 18 days old, however, version 5.0.0 of package `conventional-commits-parser` [4] is 6 months old! But the worst is that the previous version 3.0.6 (which is the one that commitlint was using before this update) was published about 4 years ago! So I'm guessing our plugins were compatible with very old versions of this internal component and now its update has exposed bugs. [1] conventional-changelog/commitlint@3423735 [2] conventional-changelog/commitlint#3942 [3] conventional-changelog/commitlint@5a01f59 [4] https://www.npmjs.com/package/conventional-commits-parser
The last version of commitlint is making our tests fail. My suspicions for why are the following: * After their massive refactoring migrating to ESM [1], they somehow changed their sub-package @commitlint/types, which I reported as bug 3942 [2]. * When fixing bug 3942 [3], they updated their dependency to `@types/conventional-commits-parser` to a higher version (from 3.0.6 to 5.0.0). Version 5.0.0 of that package is about 18 days old, however, version 5.0.0 of package `conventional-commits-parser` [4] is 6 months old! But the worst is that the previous version 3.0.6 (which is the one that commitlint was using before this update) was published about 4 years ago! So I'm guessing our plugins were compatible with very old versions of this internal component and now its update has exposed bugs. [1] conventional-changelog/commitlint@3423735 [2] conventional-changelog/commitlint#3942 [3] conventional-changelog/commitlint@5a01f59 [4] https://www.npmjs.com/package/conventional-commits-parser
Expected Behavior
Should compile (like it was compiling 2 days ago).
Current Behavior
Affected packages
Possible Solution
No response
Steps to Reproduce
npm install --verbose @commitlint/types
Log:
tsc
Context
No response
commitlint --version
19.0.0
git --version
2.40.1
node --version
18.13.0
The text was updated successfully, but these errors were encountered: