Skip to content
This repository has been archived by the owner on Feb 5, 2018. It is now read-only.

feat(mergeConfig): add defaultFinalizeContext #4

Closed
wants to merge 1 commit into from

Conversation

stevemao
Copy link
Collaborator

Makes it possible to modify the result based on the default function.

Not sure if this is a good idea?

@stevemao stevemao force-pushed the defaultFinalizeContext branch from 9604982 to b6f6f7c Compare April 10, 2016 12:21
@coveralls
Copy link

Coverage Status

Coverage increased (+0.02%) to 96.154% when pulling b6f6f7c on defaultFinalizeContext into 35285bf on master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.02%) to 96.154% when pulling b6f6f7c on defaultFinalizeContext into 35285bf on master.

@stevemao
Copy link
Collaborator Author

Default values should only be simple primitive values. Functions shouldn't have defaults. Should probably look into how API should be designed again.

@stevemao
Copy link
Collaborator Author

The API should probably look something like expressjs's middleware, promise or stream pipe where you can do something else based on the previous work.

@stevemao stevemao force-pushed the defaultFinalizeContext branch from 3c60cf8 to b6f6f7c Compare April 17, 2016 02:09
Makes it possible to modify the result based on the default function.
@stevemao
Copy link
Collaborator Author

@stevemao stevemao closed this May 10, 2016
@stevemao stevemao deleted the defaultFinalizeContext branch May 10, 2016 13:47
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants