Mutation: implement StatelessRwTx (erigontech#1670)

ethdb/mutation.go

@@ -37,6 +37,13 @@ type MutationItem struct {
 	value []byte
 }
 
+func NewBatch(tx RwTx) StatelessRwTx {
+	return &mutation{
+		db:   &TxDb{tx: tx},
+		puts: btree.New(32),
+	}
+}
+
 func (mi *MutationItem) Less(than btree.Item) bool {
 	i := than.(*MutationItem)
 	c := strings.Compare(mi.table, i.table)
@@ -103,17 +110,37 @@ func (m *mutation) ReadSequence(bucket string) (res uint64, err error) {
 }
 
 // Can only be called from the worker thread
-func (m *mutation) Get(table string, key []byte) ([]byte, error) {
+func (m *mutation) GetOne(table string, key []byte) ([]byte, error) {
 	if value, ok := m.getMem(table, key); ok {
 		if value == nil {
-			return nil, ErrKeyNotFound
+			return nil, nil
 		}
 		return value, nil
 	}
 	if m.db != nil {
-		return m.db.Get(table, key)
+		// TODO: simplify when tx can no longer be parent of mutation
+		value, err := m.db.Get(table, key)
+		if err != nil && !errors.Is(err, ErrKeyNotFound) {
+			return nil, err
+		}
+
+		return value, nil
 	}
-	return nil, ErrKeyNotFound
+	return nil, nil
+}
+
+// Can only be called from the worker thread
+func (m *mutation) Get(table string, key []byte) ([]byte, error) {
+	value, err := m.GetOne(table, key)
+	if err != nil {
+		return nil, err
+	}
+
+	if value == nil {
+		return nil, ErrKeyNotFound
+	}
+
+	return value, nil
 }
 
 func (m *mutation) Last(table string) ([]byte, []byte, error) {