Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix file link opening #1200

Merged
merged 1 commit into from
Sep 19, 2023
Merged

Fix file link opening #1200

merged 1 commit into from
Sep 19, 2023

Conversation

Utkarsh-khambra
Copy link
Collaborator

@Utkarsh-khambra Utkarsh-khambra commented Sep 13, 2023 •
edited
Loading

closes #1199, The hyperlink uri already had the correct url format so, reencoding it again with QUrl was messing up the actual filename.

@github-actions github-actions bot added the frontend Contour Terminal Emulator (GUI frontend) label Sep 13, 2023
christianparpart
christianparpart approved these changes Sep 18, 2023
View reviewed changes
Copy link
Member

@christianparpart christianparpart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Many thanks, @Utkarsh-khambra :)

christianparpart
christianparpart requested changes Sep 18, 2023
View reviewed changes
Copy link
Member

@christianparpart christianparpart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops. forgot to mention, a changelog entry is missing.

@Utkarsh-khambra Utkarsh-khambra force-pushed the bugfix/1199 branch 2 times, most recently from d1bbaef to afcebec Compare September 18, 2023 12:04
@Utkarsh-khambra @christianparpart
Fix file link opening (OSC 8)
1e290e3 
Signed-off-by: Christian Parpart <christian@parpart.family>
christianparpart
christianparpart approved these changes Sep 19, 2023
View reviewed changes
Copy link
Member

@christianparpart christianparpart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks :)

@christianparpart christianparpart merged commit b3ee571 into master Sep 19, 2023
@christianparpart christianparpart deleted the bugfix/1199 branch September 19, 2023 19:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@christianparpart christianparpart christianparpart approved these changes

Assignees
No one assigned
Labels
frontend Contour Terminal Emulator (GUI frontend)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

File links not correctly decoded
2 participants
@Utkarsh-khambra @christianparpart