fix(tools): Terminal command returns stdout but not stderr after error detected #4482
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for continuedev ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
chezsmithy
changed the title
|
@sestinj thoughts on this PR? After enabling tools for bedrock noticing it's a pretty significant barrier to tools coding with some of the test frameworks. |
sestinj
approved these changes
Mar 16, 2025
|
This is great @chezsmithy , and if you are finding other barriers please let me know. We're starting to focus a lot on tool use |
|
@sestinj the terminal refactor you are working on should keep this work in place as well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #4503
Some terminal commands like running cucumber tests seem to result in an error, but the results are returned to stdout vs stderr. This causes the terminal tool to not see the cucumber failures and is unable to fix the errors automatically.
Checklist
Screenshots
[ For visual changes, include screenshots. ]
Testing instructions
Run cucumber tests using javascript command npm run cucumber. The tests fail, and no results are observed in the tools terminal call. When setting a breakpoint stderr is empty but stdout is populated.
Curious if we should somehow concat the results so that the LLM can can see all the terminal content to process it to resolve issues.