update alpine 3.13 -> 3.15, cdk 1.105.0 -> 1.134.0 #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This brings the image to the latest versions of alpine and cdk. I needed to do this because I encountered this bug in aws-cdk: aws/aws-cdk#14738 Just doing the workaround inside a Dockerfile based on `contino/aws-cdk` did not work for me. But rebuilding the image itself did.
thalesmg
changed the title
thalesmg
force-pushed
the
update-to-1-134-0
branch
from
66eaaf1 to
d02a260
Compare
thalesmg
added a commit
to emqx/cdk-emqx-cluster
that referenced
this pull request
Nov 26, 2021
This updates the base image and the python lib versions. I needed to do this because I encountered this bug in aws-cdk: aws/aws-cdk#14738 Just doing the workaround inside a Dockerfile based on `contino/aws-cdk` did not work for me. But rebuilding the image itself did. Related PR: contino/docker-aws-cdk#6 **Don't merge before the above PR is merged and the new image released**
|
Hi @paulbygrave ! I'm just pinging you because it seems you are a maintainer of this repo. |
thalesmg
added a commit
to emqx/cdk-emqx-cluster
that referenced
this pull request
Dec 9, 2021
This updates the base image and the python lib versions. I needed to do this because I encountered this bug in aws-cdk: aws/aws-cdk#14738 Just doing the workaround inside a Dockerfile based on `contino/aws-cdk` did not work for me. But rebuilding the image itself did. Related PR: contino/docker-aws-cdk#6 **Don't merge before the above PR is merged and the new image released**
thalesmg
added a commit
to emqx/cdk-emqx-cluster
that referenced
this pull request
Dec 14, 2021
This updates the base image and the python lib versions. I needed to do this because I encountered this bug in aws-cdk: aws/aws-cdk#14738 Just doing the workaround inside a Dockerfile based on `contino/aws-cdk` did not work for me. But rebuilding the image itself did. Related PR: contino/docker-aws-cdk#6 **Don't merge before the above PR is merged and the new image released**
thalesmg
added a commit
to emqx/cdk-emqx-cluster
that referenced
this pull request
Dec 30, 2021
This updates the base image and the python lib versions. I needed to do this because I encountered this bug in aws-cdk: aws/aws-cdk#14738 Just doing the workaround inside a Dockerfile based on `contino/aws-cdk` did not work for me. But rebuilding the image itself did. Related PR: contino/docker-aws-cdk#6 **Don't merge before the above PR is merged and the new image released**
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This brings the image to the latest versions of alpine and cdk.
I needed to do this because I encountered this bug in aws-cdk:
aws/aws-cdk#14738
Just doing the workaround inside a Dockerfile based on
contino/aws-cdkdid not work for me. But rebuilding the imageitself did.