-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
**Feature:** TopbarSelect hooks #943
Merged
TejasQ
merged 14 commits into
contiamo:master
from
JoshRosenstein:feature/topbarSelect-hooks
Mar 11, 2019
Merged
**Feature:** TopbarSelect hooks #943
TejasQ
merged 14 commits into
contiamo:master
from
JoshRosenstein:feature/topbarSelect-hooks
Mar 11, 2019
Commits on Feb 28, 2019
-
Configuration menu - View commit details
-
Copy full SHA for f776e59 - Browse repository at this point
Copy the full SHA f776e59View commit details -
Configuration menu - View commit details
-
Copy full SHA for d9c7259 - Browse repository at this point
Copy the full SHA d9c7259View commit details -
Configuration menu - View commit details
-
Copy full SHA for 42f329a - Browse repository at this point
Copy the full SHA 42f329aView commit details -
Configuration menu - View commit details
-
Copy full SHA for a621acc - Browse repository at this point
Copy the full SHA a621accView commit details -
Configuration menu - View commit details
-
Copy full SHA for ff4e8dd - Browse repository at this point
Copy the full SHA ff4e8ddView commit details -
Configuration menu - View commit details
-
Copy full SHA for 858ecec - Browse repository at this point
Copy the full SHA 858ececView commit details -
Configuration menu - View commit details
-
Copy full SHA for 84a0fac - Browse repository at this point
Copy the full SHA 84a0facView commit details -
Configuration menu - View commit details
-
Copy full SHA for d77995b - Browse repository at this point
Copy the full SHA d77995bView commit details
Commits on Mar 1, 2019
-
Configuration menu - View commit details
-
Copy full SHA for 70ce1e7 - Browse repository at this point
Copy the full SHA 70ce1e7View commit details -
Configuration menu - View commit details
-
Copy full SHA for cca15d0 - Browse repository at this point
Copy the full SHA cca15d0View commit details
Commits on Mar 4, 2019
-
Configuration menu - View commit details
-
Copy full SHA for ddd19a9 - Browse repository at this point
Copy the full SHA ddd19a9View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7a06235 - Browse repository at this point
Copy the full SHA 7a06235View commit details -
Optimize TopbarSelect- Remove Hooks
Originally, i created the hooks to mimic the original code, however, now i question if the original implentation to capture window resize and use of debounce was even necessary.
Configuration menu - View commit details
-
Copy full SHA for ce04e93 - Browse repository at this point
Copy the full SHA ce04e93View commit details
Commits on Mar 6, 2019
-
Configuration menu - View commit details
-
Copy full SHA for 1f41837 - Browse repository at this point
Copy the full SHA 1f41837View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.