Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tabs hooks #941

Merged
merged 6 commits into from
Mar 4, 2019
Merged

Tabs hooks #941

merged 6 commits into from
Mar 4, 2019

Conversation

JoshRosenstein
Copy link
Contributor

Summary

Refactor Tabs to use hooks

Related issue

910

To be tested

Me

  • No error or warning in the console on localhost:6060

Tester 1

  • Things look good on the demo.

Tester 2

  • Things look good on the demo.

TejasQ
TejasQ reviewed Feb 28, 2019
View reviewed changes
Copy link
Contributor

@TejasQ TejasQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Beautiful. 😍

Given that this component too implements the render props pattern for sharing stateful logic, I'd voice the same concerns as here.

src/Internals/Tabs.tsx Outdated Show resolved Hide resolved
src/Internals/Tabs.tsx Outdated Show resolved Hide resolved
mpotomin
mpotomin reviewed Mar 4, 2019
View reviewed changes
Copy link
Contributor

@mpotomin mpotomin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's reword it a bit and I think we're good.

src/Internals/Tabs.tsx Outdated Show resolved Hide resolved
mpotomin
mpotomin approved these changes Mar 4, 2019
View reviewed changes
Copy link
Contributor

@mpotomin mpotomin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Besides the ambiguous comment, this looks good. Let's merge it. @JoshRosenstein

@mpotomin mpotomin changed the title **Feature:** Tabs hooks Tabs hooks Mar 4, 2019
TejasQ
TejasQ approved these changes Mar 4, 2019
View reviewed changes
Copy link
Contributor

@TejasQ TejasQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @JoshRosenstein

@TejasQ TejasQ merged commit f64f564 into contiamo:master Mar 4, 2019
@JoshRosenstein JoshRosenstein deleted the feature/Tabs-hooks branch March 5, 2019 02:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stereobooster stereobooster stereobooster left review comments

@mpotomin mpotomin mpotomin approved these changes

@TejasQ TejasQ TejasQ approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@JoshRosenstein @stereobooster @mpotomin @TejasQ