**Breaking:** Fix operational context #921
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stereobooster
force-pushed
the
fix-operational-context
branch
from
6941e07
to
9047510
Compare
stereobooster
force-pushed
the
fix-operational-context
branch
from
9047510
to
427439d
Compare
| @@ -0,0 +1,23 @@ | |||
| import { useEffect, useState } from "react" | |||
|
|
|||
| const useWindowSize = () => { | |||
There was a problem hiding this comment.
We don't have readme and tests for this hook
TejasQ
reviewed
Feb 14, 2019
|
|
||
| export { Context, WindowSize, IMessage, MessageType, useOperationalContext } | ||
| export default Consumer |
There was a problem hiding this comment.
Maybe we should still export the types?
| @@ -0,0 +1,23 @@ | |||
| import { useEffect, useState } from "react" | |||
|
|
|||
| const useWindowSize = () => { | |||
TejasQ
changed the title
|
Do either of you test locally? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Related issue
To be tested
Me
localhost:6060Tester 1
Tester 2