Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Any plans on moving to hooks? #908

Closed
adeelibr opened this issue Feb 4, 2019 · 6 comments
Closed

Any plans on moving to hooks? #908

adeelibr opened this issue Feb 4, 2019 · 6 comments

Comments

@adeelibr
Copy link
Contributor

adeelibr commented Feb 4, 2019

With hooks coming out of alpha version soon, is there a road map in place to move/migrate all Class components to hooks. With hooks everything is a function.

@fabien0102
Copy link
Contributor

We will probably move to hooks here 😉 We already use them in production 👼

But regarding the strategy, I don't really see the point to rewrite everything in hooks style (since the library API is the same) However it can be nice to have a hook version of our context component (to avoid nestead render props 😄 )

So let's begin by OperationalContext, rest are just for library confort. Also I will prefer to keep render props and hooks style, so don't break everything 🤠

@adeelibr Are you interest to take this feature?
@TejasQ What do you think about this strategy?

@TejasQ
Copy link
Contributor

TejasQ commented Feb 4, 2019

@fabien0102 I like your idea. Let's queue this for v14 as it will be a great breaking change. Step 1 is to update the peerDependencies entry for React to be ^16.8. 😄

@TejasQ
Copy link
Contributor

TejasQ commented Feb 4, 2019

@adeelibr, to add to @fabien0102's great answer to your question, here's a nice todo list if you're interested in contributing: #908

I'd suggest discussing further there. Please close this issue if you agree, or feel free to carry on the conversation here.

@adeelibr
Copy link
Contributor Author

adeelibr commented Feb 4, 2019

@adeelibr Are you interest to take this feature?

I would love to 👍 @fabien0102

@adeelibr, to add to @fabien0102's great answer to your question, here's a nice todo list if you're interested in contributing: #908 I'd suggest discussing further there.

This is issue #908 😅 @TejasQ

@TejasQ
Copy link
Contributor

TejasQ commented Feb 4, 2019

Oops, I meant #910 😂

@adeelibr
Copy link
Contributor Author

adeelibr commented Feb 4, 2019

Great! I am closing this issue in favor of #910, I'd like to start of working with OperationalContext initially.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants