Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: columns uses incorrect default value [] #782

Merged
merged 1 commit into from
Oct 4, 2024

Conversation

chasepoirier
Copy link
Contributor

Purpose

Columns is set to margin 0 auto 0 auto from the user_interface but the default is 0 0 0 0 in the SDK which results in the change indicator showing on initial drop of the columns component.

@chasepoirier chasepoirier requested review from a team as code owners October 4, 2024 16:57
Copy link

vercel bot commented Oct 4, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
nextjs-marketing-demo-bug-test 🔄 Building (Inspect) Visit Preview Oct 4, 2024 4:57pm
2 Skipped Deployments
Name Status Preview Updated (UTC)
experience-builder-test-app ⬜️ Ignored (Inspect) Oct 4, 2024 4:57pm
studio-nextjs-marketing-demo ⬜️ Ignored (Inspect) Oct 4, 2024 4:57pm

Copy link
Contributor

@ryunsong-contentful ryunsong-contentful left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice subtle fix

@chasepoirier chasepoirier merged commit f3fb9a4 into development Oct 4, 2024
12 checks passed
@chasepoirier chasepoirier deleted the fix/column-default-margin branch October 4, 2024 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants