fix(core): resolving design values [ALT-1222] #744

primeinteger · 2024-09-11T18:45:06Z

Allow getBreakpointByValue to return raw design values without resolving design tokens

When calling this method from the UI, we don't want design tokens to be resolved into values, because we want to design sidebar input to use the string template design token value in order to show the design token badge element.
When this method is called from the SDK side, we do want any design token values to be resolved into css values

…en values [ALT-1222]

vercel · 2024-09-11T18:45:10Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Updated (UTC)
experience-builder-test-app	✅ Ready (Inspect)	Visit Preview	Sep 11, 2024 10:49pm

…s fixture

fix(core): allow getBreakpointByValue to return unresolved design tok…

ffb5a4f

…en values [ALT-1222]

primeinteger requested review from a team as code owners September 11, 2024 18:45

ryunsong-contentful approved these changes Sep 11, 2024

View reviewed changes

fix: add unit test

ebc834f

vercel bot deployed to Preview September 11, 2024 20:09 View deployment

fix: add more unit tests

1d49472

vercel bot deployed to Preview September 11, 2024 22:42 View deployment

fix: revised unit test to use design token values from the definition…

7f35533

…s fixture

vercel bot deployed to Preview September 11, 2024 22:49 View deployment

primeinteger merged commit 93c9cc5 into development Sep 11, 2024
12 checks passed

primeinteger deleted the ALT-1222/breakpoints branch September 11, 2024 23:14

Provide feedback