Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix vulnrerable dependency #133

Merged
merged 1 commit into from
Sep 10, 2018
Merged

Fix vulnrerable dependency #133

merged 1 commit into from
Sep 10, 2018

Conversation

Khaledgarbaya
Copy link
Contributor

@Khaledgarbaya Khaledgarbaya commented Sep 10, 2018 •
edited
Loading

Summary

string.js which is a dependency of nixt is vulnerable.
This PR fixes that.
Even though the vulnerable code is not used it's good to remove it.

phoebeschmidt
phoebeschmidt approved these changes Sep 10, 2018
View reviewed changes
Copy link
Contributor

@phoebeschmidt phoebeschmidt left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dont understand why checks are hitting rate limits instead of using nock recordings? but otherwise 👍

@Khaledgarbaya
Copy link
Contributor Author

@phoebeschmidt the recording is only used with integration test and not with e2e that's why

@Khaledgarbaya Khaledgarbaya merged commit 6e058d6 into master Sep 10, 2018
@anho anho deleted the fix/vulrable-dep branch November 25, 2020 06:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phoebeschmidt phoebeschmidt phoebeschmidt approved these changes

@axe312ger axe312ger Awaiting requested review from axe312ger

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Khaledgarbaya @phoebeschmidt