-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add resourceProvider methods [DANTE-1405] #2415
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cyberxon
force-pushed
the
feat/resource-types-entities
branch
from
August 29, 2024 08:22
763cb48
to
777cb77
Compare
Cyberxon
force-pushed
the
feat/resource-types-entities
branch
from
August 29, 2024 08:22
777cb77
to
bb78d19
Compare
Cyberxon
changed the title
feat: add resourceProvider methods
feat: add resourceProvider methods [DANTE-1405]
Aug 29, 2024
mayakarabula
approved these changes
Aug 29, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
mgoudy91
approved these changes
Aug 29, 2024
🎉 This PR is included in version 11.33.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
To give our users and ourselves more convenient access to the new entities:
resourceProviders
,resourceTypes
andresources
, we should add them to the contentful-management.js JavaScript library. The library currently contains two separate client implementations that need to be updated: the legacy client and the plain client. This PR adds the first entity,resourceProvider
, to both clients.Description
This PR adds new methods to CRUD resourceProviders:
Motivation and Context
Checklist (check all before merging)
When adding a new method:
./lib/export-types.ts