Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add resourceProvider methods [DANTE-1405] #2415

Merged
merged 7 commits into from
Aug 30, 2024

Conversation

mohamedturki
Copy link
Member

@mohamedturki mohamedturki commented Aug 21, 2024

Summary

To give our users and ourselves more convenient access to the new entities: resourceProviders, resourceTypes and resources, we should add them to the contentful-management.js JavaScript library. The library currently contains two separate client implementations that need to be updated: the legacy client and the plain client. This PR adds the first entity, resourceProvider, to both clients.

Description

This PR adds new methods to CRUD resourceProviders:

  • Legacy client:
  1. AppDefinition methods to upsert and get resourceProviders
  2. ResourceProvider methods to upsert and delete a given resource provider
  • Plain client:
  1. ResourceProvider methods to get, upsert and delete a given resource provider

Motivation and Context

Checklist (check all before merging)

  • Both unit and integration tests are passing
  • There are no breaking changes
  • Changes are reflected in the documentation

When adding a new method:

  • The new method is exported through the default and plain CMA client
  • All new public types are exported from ./lib/export-types.ts
  • Added a unit test for the new method
  • Added an integration test for the new method
  • The new method is added to the documentation

@Cyberxon Cyberxon force-pushed the feat/resource-types-entities branch from 763cb48 to 777cb77 Compare August 29, 2024 08:22
@Cyberxon Cyberxon force-pushed the feat/resource-types-entities branch from 777cb77 to bb78d19 Compare August 29, 2024 08:22
@Cyberxon Cyberxon changed the title wip feat: add resourceProvider methods Aug 29, 2024
@Cyberxon Cyberxon marked this pull request as ready for review August 29, 2024 08:33
@Cyberxon Cyberxon requested a review from a team as a code owner August 29, 2024 08:33
@Cyberxon Cyberxon changed the title feat: add resourceProvider methods feat: add resourceProvider methods [DANTE-1405] Aug 29, 2024
Copy link
Member

@mayakarabula mayakarabula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Cyberxon Cyberxon merged commit d0b5247 into master Aug 30, 2024
5 of 6 checks passed
@Cyberxon Cyberxon deleted the feat/resource-types-entities branch August 30, 2024 13:23
@contentful-automation
Copy link
Contributor

🎉 This PR is included in version 11.33.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants