This repository was archived by the owner on Dec 11, 2024. It is now read-only.
(MINOR) Rework c2patool parameters #53
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…patool into external_manifest * 'external_manifest' of https://github.com/contentauth/c2patool: update c2pa version, clippy fixes # Conflicts: # Cargo.toml
source file must always be passed manifest config is always an option won't overwrite files without -force flag Code restructure
|
Asking for review from @crandmck given substantial documentation changes. |
Add reminder about version changes being generated automatically on publish.
scouten-adobe
approved these changes
Aug 18, 2022
crandmck
approved these changes
Aug 18, 2022
…patool into gpeacock/parameter_change
3 tasks
Codecov Report
@@ Coverage Diff @@
## main #53 +/- ##
==========================================
- Coverage 75.00% 72.60% -2.40%
==========================================
Files 3 3
Lines 216 230 +14
==========================================
+ Hits 162 167 +5
- Misses 54 63 +9
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
scouten-adobe
pushed a commit
to contentauth/c2pa-rs
that referenced
this pull request
Dec 10, 2024
* Change in command line parameters for adding manifests, please review README * Support for external/remote manifests * update c2pa version * Updated Readme with new options * Change in command line parameters for adding manifests, please review README ** source file must now always be passed on command line ** manifest config now requires a -m --manifest option ** won't overwrite files without -force flag Code restructure Co-authored-by: Maurice Fisher <mfisher@adobe.com> Co-authored-by: Eric Scouten <scouten@adobe.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes in this pull request
Viewing files works the same, Manifest creation parameters are different.
source file must always be passed
manifest config must be passed with the new -m/manifest option
won't overwrite files without the new -f/force flag
Code restructure
-v -s combo no longer deletes the sidecar
Checklist
TO DOitems (or similar) have been entered as GitHub issues and the link to that issue has been included in a comment.