Skip to content
This repository was archived by the owner on Dec 11, 2024. It is now read-only.

Pull in latest bug fixes #237

Merged
merged 12 commits into from
Sep 17, 2024
Merged

Pull in latest bug fixes #237

merged 12 commits into from
Sep 17, 2024

Conversation

mauricefisher64
Copy link
Contributor

Changes in this pull request

Update to get RIFF fix and EC signature patched for incorrect signers

Checklist

  • This PR represents a single feature, fix, or change.
  • All applicable changes have been documented.
  • Any TO DO items (or similar) have been entered as GitHub issues and the link to that issue has been included in a comment.

Copy link
Contributor

@dyro dyro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@codecov-commenter
Copy link

codecov-commenter commented Sep 12, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 16.66667% with 5 lines in your changes missing coverage. Please review.

Project coverage is 41.79%. Comparing base (17863bd) to head (5104408).
Report is 17 commits behind head on main.

Files with missing lines Patch % Lines
src/main.rs 16.66% 5 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

❗ There is a different number of reports uploaded between BASE (17863bd) and HEAD (5104408). Click for more details.

HEAD has 9 uploads less than BASE
Flag BASE (17863bd) HEAD (5104408)
12 3
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #237      +/-   ##
==========================================
- Coverage   48.68%   41.79%   -6.89%     
==========================================
  Files           4        4              
  Lines         684      756      +72     
==========================================
- Hits          333      316      -17     
- Misses        351      440      +89     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mauricefisher64 mauricefisher64 merged commit 6dd6253 into main Sep 17, 2024
9 checks passed
@mauricefisher64 mauricefisher64 deleted the ec_riff_fixes branch September 17, 2024 12:56
scouten-adobe added a commit to contentauth/c2pa-rs that referenced this pull request Dec 10, 2024
* Pull in latest bug fixes

* clippy fixes

* Test build fix

* Clippy fixes.

* Try again?

---------

Co-authored-by: Eric Scouten <scouten@adobe.com>
Co-authored-by: Gavin Peacock <gpeacock@adobe.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants