Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "fix(deps): update module github.com/cyphar/filepath-securejoin to v0.4.0" #2216

Merged
merged 1 commit into from
Jan 21, 2025

Conversation

Luap99
Copy link
Member

@Luap99 Luap99 commented Jan 21, 2025

This reverts commit 05dcfd3.

In particular this commit doesn't build when vendored into podman because runc fails to build with it.
opencontainers/runc#4590

This is not visible in storage because runc is not imported here.

…n to v0.4.0"

This reverts commit 05dcfd3.

In particular this commit doesn't build when vendored into podman
because runc fails to build with it.
opencontainers/runc#4590

This is not visible in storage because runc is not imported here.

Signed-off-by: Paul Holzinger <pholzing@redhat.com>
@Luap99
Copy link
Member Author

Luap99 commented Jan 21, 2025

@mtrmac @nalind @rhatdan @mheon @TomSweeneyRedHat PTAL
This will block the podman v5.4 vendor dance if we do not merge this.

@mtrmac
Copy link
Collaborator

mtrmac commented Jan 21, 2025

/lgtm
/approve

Copy link
Contributor

openshift-ci bot commented Jan 21, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Luap99, mtrmac

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit c2cdd50 into containers:main Jan 21, 2025
20 checks passed
@Luap99 Luap99 deleted the revert-securejoin-0.4 branch January 21, 2025 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants