Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fall back from partial pull when on VFS #2140

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Fall back from partial pull when on VFS #2140

wants to merge 4 commits into from
+70 −42

Commits on Oct 18, 2024

  1. Split getProperDiffer from GetDiffer 

    ... to centralize the fallback allowed / required logic.

Should not change behavior, apart from maybe some error text.

Signed-off-by: Miloslav Trmač <mitr@redhat.com>
    @mtrmac
    mtrmac committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    8e39387 View commit details
    Browse the repository at this point in the history

  2. Refactor getProperDiffer a bit 

    Instead of sharing the badRequestErr logic, duplicate it.
That's a bit ugly, but we get better debug messages and a more
traditional control flow.

Should not change behavior, except for debug messages.

Signed-off-by: Miloslav Trmač <mitr@redhat.com>
    @mtrmac
    mtrmac committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    da9f66a View commit details
    Browse the repository at this point in the history

  3. Refactor getProperDiffer further 

    Use switch to handle the various TOC presence cases

Signed-off-by: Miloslav Trmač <mitr@redhat.com>
    @mtrmac
    mtrmac committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    bdbd5ed View commit details
    Browse the repository at this point in the history

  4. Fall back from partial pulls to ordinary pulls on VFS 

    ... and other graph drivers which don't support partial pulls.

Signed-off-by: Miloslav Trmač <mitr@redhat.com>
    @mtrmac
    mtrmac committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    82234e1 View commit details
    Browse the repository at this point in the history