-
Notifications
You must be signed in to change notification settings - Fork 241
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
overlay: select additional image store path when using image store #1732
Conversation
If parentBase path is additional image store, select the image contained in parentBase. Otherwise, the overlay storage driver may select another image store that does not contain the desired image, causing a "no suche file or directory" error. Fixes: containers/podman#19748 Signed-off-by: Toshiki Sonoda <sonoda.toshiki@fujitsu.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thanks @sstosh
@giuseppe PTAL |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
would it be possible to get a test for this case?
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: flouthoc, giuseppe, sstosh The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
LGTM |
@sstosh Could you open a PR against podman with vendor of this PR uncommenting |
Clarification: there is absolutely no point to opening a podman PR, because podman CI e2e tests do not test overlay. Please don't bother. I'm testing it now in #17831. |
New code passes under overlay:
LGTM. Thank you @sstosh! |
If parentBase path is additional image store, select the image contained in parentBase.
Otherwise, the overlay storage driver may select another image store that does not contain
the desired image, causing a
no suche file or directory
error.Fixes: containers/podman#19748