Fix error detection in quad_split_string_append()

containers · Dec 21, 2021 · 216885e · 216885e
1 parent 82d7c2f
commit 216885e
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 3 deletions.
diff --git a/src/utils.c b/src/utils.c
@@ -494,7 +494,7 @@ extract_first_word (const char **p, char **ret, const char *separators, QuadSpli
   return 1;
 }
 
-void
+gboolean
 quad_split_string_append (GPtrArray *array,
                           const char *s,
                           const char *separators,
@@ -508,13 +508,15 @@ quad_split_string_append (GPtrArray *array,
 
       r = extract_first_word (&s, &word, separators, flags);
       if (r < 0)
-        return NULL;
+        return FALSE;
 
       if (r == 0)
         break;
 
       g_ptr_array_add (array, g_steal_pointer (&word));
     }
+
+  return TRUE;
 }
 
 GPtrArray *

diff --git a/src/utils.h b/src/utils.h
@@ -37,7 +37,7 @@ char *                quad_apply_line_continuation (const char     *raw_string);
 GPtrArray *           quad_split_string            (const char     *s,
                                                     const char     *separators,
                                                     QuadSplitFlags  flags);
-void                  quad_split_string_append     (GPtrArray      *array,
+gboolean              quad_split_string_append     (GPtrArray      *array,
                                                     const char     *s,
                                                     const char     *separators,
                                                     QuadSplitFlags  flags);