Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ffi: Adding modprobe modules case. #449

Merged
merged 1 commit into from
Jun 2, 2024
Merged

ffi: Adding modprobe modules case. #449

merged 1 commit into from
Jun 2, 2024

Conversation

weiwang-linda
Copy link
Contributor

@weiwang-linda weiwang-linda commented May 29, 2024 •
edited by Yarboa
Loading

Adding a ffi test to check it won't be possible to access /lib/modules to load any module via modprobe inside the QM partition.
resolve #373

Make sure it won't be possible to access /lib/modules to load any module via modprobe inside QM container, like below:

bash-5.1# modprobe ext4
modprobe: FATAL: Module ext4 not found in directory /lib/modules/5.14.0-438.391.el9iv.x86_64
bash-5.1# ls /lib/modules/5.14.0-438.391.el9iv.x86_64
ls: cannot access '/lib/modules/5.14.0-438.391.el9iv.x86_64': No such file or directory

@weiwang-linda weiwang-linda self-assigned this May 29, 2024
Yarboa
Yarboa reviewed May 30, 2024
View reviewed changes
Copy link
Collaborator

@Yarboa Yarboa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please edit description with resolve #issue_id, and explain what is the desired out put
the tests are verified by packit, no need to add it here

@Yarboa
Copy link
Collaborator

Yarboa commented Jun 1, 2024

/packit test

dougsland
dougsland reviewed Jun 1, 2024
View reviewed changes
tests/ffi/modules/test.sh Outdated Show resolved Hide resolved
@Yarboa
Copy link
Collaborator

Yarboa commented Jun 1, 2024

/packit test --identifier e2e-tiers

@weiwang-linda
Add new case for modprobe modules
48fa529 
Check it won't be possible to access /lib/modules to load any module via modprobe inside the QM partition.

Jira-URL: https://issues.redhat.com/browse/VROOM-19336
Signed-off-by: weiwang <weiwang@redhat.com>
Yarboa
Yarboa approved these changes Jun 2, 2024
View reviewed changes
Copy link
Collaborator

@Yarboa Yarboa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Yarboa Yarboa merged commit 8f3439b into containers:main Jun 2, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Yarboa Yarboa Yarboa approved these changes

@rhatdan rhatdan Awaiting requested review from rhatdan rhatdan is a code owner

@lsm5 lsm5 Awaiting requested review from lsm5 lsm5 is a code owner

@odra odra Awaiting requested review from odra

@sandrobonazzola sandrobonazzola Awaiting requested review from sandrobonazzola sandrobonazzola is a code owner

@dennisbrendel dennisbrendel Awaiting requested review from dennisbrendel

@priyverm priyverm Awaiting requested review from priyverm

@dougsland dougsland Awaiting requested review from dougsland dougsland is a code owner

Assignees

@weiwang-linda weiwang-linda

Labels
ffi testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

FFI: modprobe - test interference from the QM partition to host
3 participants
@weiwang-linda @Yarboa @dougsland