Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #9100 Change console mode message to debug #9101

Merged
merged 1 commit into from
Jan 27, 2021
Merged

Fix #9100 Change console mode message to debug #9101

merged 1 commit into from
Jan 27, 2021

Conversation

gbraad
Copy link
Member

@gbraad gbraad commented Jan 26, 2021

When using PowerShel the console mode continously shows as an error message.
This doesn't happen for the Command prompt on Windows. As it does not affect
the functionality, it is probably betetr to treat this as a debug log level?

vrothberg
vrothberg reviewed Jan 26, 2021
View reviewed changes
Copy link
Member

@vrothberg vrothberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

@vrothberg
Copy link
Member

To make CI happy, you need to sign the commit git commit -s --amend.

@rhatdan
Copy link
Member

rhatdan commented Jan 26, 2021

LGTM
Sign and repush and we can get this merged and into podman 3.0

@TomSweeneyRedHat
Copy link
Member

LGTM
assming happy tests

@gbraad
Fix #9100 Change console mode message to debug
e9f4fb9 
[NO TESTS NEEDED]

Signed-off-by: Gerard Braad <me@gbraad.nl>
@zhangguanzhang
Copy link
Collaborator

Fixes: #9100

@zhangguanzhang
Copy link
Collaborator

/approve
/lgtm

@openshift-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gbraad, zhangguanzhang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jan 27, 2021
@openshift-merge-robot openshift-merge-robot merged commit c3b3984 into containers:master Jan 27, 2021
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 23, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@vrothberg vrothberg vrothberg left review comments

Assignees

@zhangguanzhang zhangguanzhang

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@gbraad @vrothberg @rhatdan @TomSweeneyRedHat @zhangguanzhang @openshift-ci-robot @openshift-merge-robot