rootless container creation settings #8245
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: baude The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
baude
force-pushed
the
rootlesscreatecompat
branch
from
65325d8 to
e815e0d
Compare
|
this PR is in support of the tests that @jwhonce is readying for submission which is why i didnt add any. |
|
@jwhonce this is for you |
rhatdan
reviewed
Nov 4, 2020
mheon
reviewed
Nov 4, 2020
baude
force-pushed
the
rootlesscreatecompat
branch
from
e815e0d to
a8a650e
Compare
giuseppe
reviewed
Nov 5, 2020
mheon
reviewed
Nov 5, 2020
mheon
reviewed
Nov 5, 2020
when running container creation as rootless on the compatibility layer, we need to make sure settings are not being done for memory and memory swappiness. Signed-off-by: baude <bbaude@redhat.com>
baude
force-pushed
the
rootlesscreatecompat
branch
from
a8a650e to
71a4676
Compare
|
LGTM |
|
/lgtm |
github-actions
bot
added
the
locked - please file new issue/PR
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
when running container creation as rootless on the compatibility layer, we need to make sure settings are not being done for memory and memory swappiness