Improve error messages from failing tests #8225
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rhatdan
reviewed
Nov 3, 2020
rhatdan
reviewed
Nov 3, 2020
rhatdan
reviewed
Nov 3, 2020
rhatdan
reviewed
Nov 3, 2020
rhatdan
reviewed
Nov 3, 2020
| @@ -280,7 +274,7 @@ var _ = Describe("Podman exec", func() { | |||
| exec := podmanTest.Podman([]string{"exec", "-ti", ctrName2, "id"}) | |||
| exec.WaitWithDefaultTimeout() | |||
| Expect(exec.ExitCode()).To(Equal(0)) | |||
| Expect(strings.Contains(exec.OutputToString(), fmt.Sprintf("%s(%s)", gid, groupName))).To(BeTrue()) | |||
| Expect(exec.OutputToString()).To(ContainSubstring(fmt.Sprintf("%s(%s)", gid, groupName))) | |||
There was a problem hiding this comment.
The output of id would at least also have the UID, so we can't just use Equal without further changes to the test.
rhatdan
approved these changes
Nov 3, 2020
openshift-ci-robot
added
the
approved
Using a function like ContainSubstring or Equal is better because if the test fails it will log a descriptive error that includes the actual string generated during the test. This is more helpful than a function like BeTrue that will only indicate that an assertion failed without giving further details of the failure. Signed-off-by: Debarshi Ray <rishi@fedoraproject.org>
|
Thanks for the review! |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: debarshiray, rhatdan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/lgtm |
github-actions
bot
added
the
locked - please file new issue/PR
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using a function like ContainSubstring is better because if the test
fails it will log a descriptive error that includes the actual string
generated during the test. This is more helpful than a function like
BeTrue that will only indicate that an assertion failed without giving
further details of the failure.
Signed-off-by: Debarshi Ray rishi@fedoraproject.org