error when adding container to pod with network information #7390
Conversation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: baude The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
|
Does this handle #7373? |
|
Yep, it does fix #7376 |
| return errors.Wrap(define.ErrNetworkOnPodContainer, "MAC addresses must be defined when the pod is created") | ||
| } | ||
| if len(s.CNINetworks) > 0 { | ||
| return errors.Wrap(define.ErrNetworkOnPodContainer, "networks must be defined when the pod is created") |
There was a problem hiding this comment.
AFAIK This can't happen. If I use --net foobar the container won't join the pod namespace.
There was a problem hiding this comment.
Theoretically people could pass this via the REST API, so this would catch that.
There was a problem hiding this comment.
Ah, didn't knew you can set the netns separately via the api.
because a pod's network information is dictated by the infra container at creation, a container cannot be created with network attributes. this has been difficult for users to understand. we now return an error when a container is being created inside a pod and passes any of the following attributes: * static IP (v4 and v6) * static mac * ports -p (i.e. -p 8080:80) * exposed ports (i.e. 222-225) * publish ports from image -P Signed-off-by: Brent Baude <bbaude@redhat.com>
|
/lgtm |
github-actions
bot
added
the
locked - please file new issue/PR
because a pod's network information is dictated by the infra container at creation, a container cannot be created with network attributes. this has been difficult for users to understand. we now return an error when a container is being created inside a pod and passes any of the following attributes:
Signed-off-by: Brent Baude bbaude@redhat.com